Skip to content

Add Azure OpenAI validation tests #6401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ArivunidhiA wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Azure OpenAI validation tests #6401

ArivunidhiA wants to merge 1 commit into from
+40 −0

Conversation

@ArivunidhiA
Copy link

@ArivunidhiA ArivunidhiA commented Feb 11, 2026 •
edited
Loading

Problem and motivation: Azure OpenAI requires api_version, deployment_id, and api_base. Missing values fail at runtime, so these tests lock in that validation. Context: #1770.

Summary of changes:

  • add tests for missing deployment_id, api_version, and api_base
  • assert InvalidArgumentError is raised when required values are absent

Testing:

python -m pytest chromadb/test/ef/test_openai_ef.py -v

Impact and risks: no backward compatibility changes, only adds tests. Docs or comments: not needed. CI: not run locally. Reviewer focus: test expectations and error messages.

@github-actions
Copy link

github-actions bot commented Feb 11, 2026

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@propel-code-bot
Copy link
Contributor

propel-code-bot bot commented Feb 11, 2026 •
edited
Loading

These cases explicitly exercise the Azure-specific OpenAIEmbeddingFunction to guard its argument validation path against future regressions.

This summary was automatically generated by @propel-code-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ArivunidhiA